Fix bad assumption about base repo identification #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works for ISO and I have a feeling this is not true for repo files. Fedora don't have naming of the repository that we are able to identify base repository so when we don't found base repository on the ISO we will just use root of the ISO as base repository and see how it goes. Our tests for valid ISO where too strict about this. Right now we will look for base repo and if that is not found we will look on repo which has repository in the root. Resolves: rhbz#1691832
In case the validation of the ISO goes wrong we will handle the ISO as directory containing the repositories. From this commit further we will first test if it is really a directory before doing that. Related: rhbz#1691832
jkonecny12
added
master
poncovka
approved these changes
Apr 8, 2019
jkonecny12
removed
the
manual testing required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bad assumption about base repo identification (#1691832) …
This works for ISO and I have a feeling this is not true for repo files.
Fedora don't have naming of the repository that we are able to identify base repository so when we don't found base repository on the ISO we will just use root of the ISO as base repository and see how it goes.
Our tests for valid ISO where too strict about this. Right now we will look for base repo and if that is not found we will look on repo which has repository in the root.
Also fail (Source spoke fail) instead of trying to use ISO as directory source and fallbacking to closest mirror then.
I will test properly if this won't break something else... :(